-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Attempting to fix Yarn 2 PNP test #1570
Conversation
|
Ouch, sorry this issue made you come to that conclusion. To give some context on what's going on here: EDIT: |
Oh it's most certainly not just this issue, but the myriad of issues/discussions that have been raised (and raised again and again) about Yarn's future. I'm not against merging in any PR's that help compat like your own #1418, or even having code that does nothing but support Yarn 2, but I do disagree with spending any time ensuring compat ourselves. It's just not an effective use of time for a niche tool which breaks compat with a ton of the ecosystem. |
We've fixed it on our side so this can be closed as the next CI run will pick up the fix on its own |
What kind of change does this PR introduce?
CI fix
Did you add tests for your changes?
Existing cover this
Summary
yarnpkg/berry#2935
Honestly Yarn 2 seems to be so broken in the ecosystem at large & unused I don't think it's worth the time testing against.
Does this PR introduce a breaking change?
No